Skip to content

Add OrvexCL PancakeInfinity fork to Robinhood - #621

Merged
duncancmt merged 7 commits into
masterfrom
e1Ru1o/orvex
Aug 18, 2026
Merged

Add OrvexCL PancakeInfinity fork to Robinhood#621
duncancmt merged 7 commits into
masterfrom
e1Ru1o/orvex

Conversation

@e1Ru1o

@e1Ru1o e1Ru1o commented Aug 7, 2026

Copy link
Copy Markdown
Member

No description provided.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@e1Ru1o
e1Ru1o requested a review from jparklev August 7, 2026 18:41
@e1Ru1o e1Ru1o self-assigned this Aug 7, 2026
@immunefi-magnus

Copy link
Copy Markdown

🛡️ Immunefi PR Reviews

We noticed that your project isn't set up for automatic code reviews. If you'd like this PR reviewed by the Immunefi team, you can request it manually using the link below:

🔗 Send this PR in for review

Once submitted, we'll take care of assigning a reviewer and follow up here.

@jparklev jparklev left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@duncancmt duncancmt left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but the flexibility of the pattern (inversion of control) makes me worry about whether this introduces the possibility of future footguns. I think a defensively-programmed variation may also improve gas efficiency, but this is just a hunch.

Comment thread src/core/PancakeInfinity.sol Outdated
Comment thread src/core/pancakeInfinityForks/OrvexCL.sol Outdated
Comment thread src/core/PancakeInfinity.sol Outdated
e1Ru1o and others added 2 commits August 17, 2026 17:07
## Description

Adds fork integration tests for the OrvexCL (PancakeSwap Infinity fork)
integration on RobinHood:

- `test/integration/OrvexCL.t.sol`: `OrvexCLTest` harness targeting the
`robinhood` fork with the RobinHood settler flavors and the Orvex
vault/CL manager (`binPoolManager()` is `address(0)` since Orvex has no
Bin pool manager), plus a concrete WETH→NVDA pair test against the
deepest hookless Orvex CL pool
(`0x257df135116403937e4b04b22b796e6746d965090fef574b684c9c294c542490`,
fee 3000).
- `test/integration/PancakeInfinity.t.sol`: the harness previously
hardcoded the canonical PancakeSwap Infinity addresses; the vault and
pool manager addresses are now virtual functions
(`vault()`/`clPoolManager()`/`binPoolManager()`) defaulting to
canonical, so the existing Bnb pair tests are unchanged.
- `foundry.toml`: `robinhood` RPC endpoint alias.
- `.github/workflows/integration.yml`: passes
`ROBINHOOD_MAINNET_RPC_URL` to the integration test run.
- Gas snapshots for the new tests.

Covered paths, all executing real swaps through the Orvex vault lock →
settler callback → Orvex CL manager:

```
[PASS] testPancakeInfinity()                    taker-submitted, settler-held balance
[PASS] testPancakeInfinityVIP()                 Permit2 VIP
[PASS] testPancakeInfinityVIPAllowanceHolder()  AllowanceHolder
[PASS] testPancakeInfinityMetaTxn()             MetaTxn flavor
```

## ⚠️ Before merging

The `ROBINHOOD_MAINNET_RPC_URL` repository secret must be added,
otherwise the integration workflow cannot fork RobinHood and the new
tests will fail in CI.

🤖 Generated with [Claude Code](https://claude.com/claude-code)
@e1Ru1o
e1Ru1o requested a review from dekz as a code owner August 18, 2026 12:29
@duncancmt
duncancmt merged commit 5112e42 into master Aug 18, 2026
4 checks passed
@duncancmt
duncancmt deleted the e1Ru1o/orvex branch August 18, 2026 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants