Add OrvexCL PancakeInfinity fork to Robinhood - #621
Merged
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
🛡️ Immunefi PR ReviewsWe noticed that your project isn't set up for automatic code reviews. If you'd like this PR reviewed by the Immunefi team, you can request it manually using the link below: Once submitted, we'll take care of assigning a reviewer and follow up here. |
duncancmt
approved these changes
Aug 12, 2026
duncancmt
left a comment
Collaborator
There was a problem hiding this comment.
This looks good, but the flexibility of the pattern (inversion of control) makes me worry about whether this introduces the possibility of future footguns. I think a defensively-programmed variation may also improve gas efficiency, but this is just a hunch.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
duncancmt
approved these changes
Aug 17, 2026
## Description Adds fork integration tests for the OrvexCL (PancakeSwap Infinity fork) integration on RobinHood: - `test/integration/OrvexCL.t.sol`: `OrvexCLTest` harness targeting the `robinhood` fork with the RobinHood settler flavors and the Orvex vault/CL manager (`binPoolManager()` is `address(0)` since Orvex has no Bin pool manager), plus a concrete WETH→NVDA pair test against the deepest hookless Orvex CL pool (`0x257df135116403937e4b04b22b796e6746d965090fef574b684c9c294c542490`, fee 3000). - `test/integration/PancakeInfinity.t.sol`: the harness previously hardcoded the canonical PancakeSwap Infinity addresses; the vault and pool manager addresses are now virtual functions (`vault()`/`clPoolManager()`/`binPoolManager()`) defaulting to canonical, so the existing Bnb pair tests are unchanged. - `foundry.toml`: `robinhood` RPC endpoint alias. - `.github/workflows/integration.yml`: passes `ROBINHOOD_MAINNET_RPC_URL` to the integration test run. - Gas snapshots for the new tests. Covered paths, all executing real swaps through the Orvex vault lock → settler callback → Orvex CL manager: ``` [PASS] testPancakeInfinity() taker-submitted, settler-held balance [PASS] testPancakeInfinityVIP() Permit2 VIP [PASS] testPancakeInfinityVIPAllowanceHolder() AllowanceHolder [PASS] testPancakeInfinityMetaTxn() MetaTxn flavor ``` ##⚠️ Before merging The `ROBINHOOD_MAINNET_RPC_URL` repository secret must be added, otherwise the integration workflow cannot fork RobinHood and the new tests will fail in CI. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.